Add edition to patterns #61
Conversation
|
@dreulavelle update the PR target branch as dev |
|
Done, my apologies! |
|
Feel free to edit the regex as you like. |
| (r"\bUltimate{d}Edition\b".format(d=delimiters), "Ultimate Edition"), | ||
| (r"\bExtended{d}Director\"?s\b".format(d=delimiters), "Directors Cut"), # Needs to be before "Extended" | ||
| (r"\bExtended\b", "Extended Edition"), | ||
| (r"\bDirector\"?s{d}Cut\b".format(d=delimiters), "Directors Cut"), |
There was a problem hiding this comment.
you may combine the "Directors Cut"
There was a problem hiding this comment.
I can fix this tonight, thanks! Did you just want it on one line separated with a pipe? Or just cover director instead of both edge cases?
There was a problem hiding this comment.
Ah I'll combine, checking extended first
There was a problem hiding this comment.
one line separated with a pipe
|
Hey! Thanks for opening the PR. Extended editions & directors cuts are already fields: As for "Ultimate" and "Anniversary" editions, we can add these if there are enough example titles to work from - I don't like adding new fields unless I see several examples of them from real torrents. If you can provide these (just the titles though! don't include torrent URLs here), we can think about adding them. This would likely be as 2 separate fields, similar to Also, please make sure all tests pass when opening a PR! If you had run them, you might have noticed the duplicate fields. Maybe re-read Contributing. Additionally, the second test you provided doesn't make sense - the output given doesn't match the input. Based on the input though, I've improved the Thanks again, and let me know your thoughts! |
This could possibly use some slight tweaking, but it works well. Let me know if anything needs changed!
Added 2 tests as well.
Ex:
"The.Lord.of.the.Rings.The.Fellowship.of.the.Ring.2001.EXTENDED.2160p.UHD.BluRay.x265.10bit.HDR.TrueHD.7.1.Atmos-BOREDOR"
{ "resolution": "2160p", "quality": "Blu-ray", "year": 2001, "codec": "H.265", "audio": "Dolby TrueHD 7.1", "extended": true, "bitDepth": 10, "hdr": true, "edition": "Extended Edition", "title": "The Lord of the Rings The Fellowship of the Ring", "encoder": "BOREDOR" }