Skip to content

SDK Update #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mzueva wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SDK Update #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/wise-dingos-wish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@platforma-open/milaboratories.clonotype-browser-3.model": patch
"@platforma-open/milaboratories.clonotype-browser-3.ui": patch
---

SDK update
6 changes: 6 additions & 0 deletions model/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ export const platforma = BlockModelV3.create(blockDataModel)
columns: [...splitSnapshots, ...nonSplitDirect, ...linked],
primaryJoinType: "full",
tableState: ctx.data.overlapTableState,
labelsOptions: {
formatters: { linker: () => undefined },

@gemini-code-assist gemini-code-assist Bot May 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Returning undefined from the linker formatter typically instructs the SDK to use the default label formatting. If the intention is to suppress the linker name in the column headers (e.g., to keep them concise), you should return an empty string '' instead. Additionally, this configuration is duplicated in the sampleTable definition; consider extracting it to a shared constant to maintain consistency and reduce duplication.

Suggested change
formatters: { linker: () => undefined },
formatters: { linker: () => '' },
References
  1. Avoid complex and duplicated logic for ensuring unique column labels. Simplify the implementation, for example, by refactoring it into a single function that adds a numeric suffix to duplicates.

},
displayOptions: {
visibility: [
{
Expand Down Expand Up @@ -202,6 +205,9 @@ export const platforma = BlockModelV3.create(blockDataModel)
],
},
},
labelsOptions: {
formatters: { linker: () => undefined },

@gemini-code-assist gemini-code-assist Bot May 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

As with the overlapTable definition, if the goal is to hide the linker name, return '' instead of undefined. This configuration is duplicated and should ideally be refactored into a shared constant.

Suggested change
formatters: { linker: () => undefined },
formatters: { linker: () => '' },
References
  1. Avoid complex and duplicated logic for ensuring unique column labels. Simplify the implementation, for example, by refactoring it into a single function that adds a numeric suffix to duplicates.

},
tableState: ctx.data.sampleTableState,
});
})
Expand Down
Loading
Loading