Fix imputeGermline having no effect when assemblingFeature is CDR3#88
Merged
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR fixes a bug where setting
imputeGermline=truehad no effect whenassemblingFeaturewasCDR3. The root cause was thatparseAssemblingFeaturereturned an emptyimputedlist for CDR3 (treating it identically toVDJRegion), so no germline-imputed columns or MiXCR export args were ever produced.calculate-export-specs.lib.tengo):parseAssemblingFeaturenow returns[\"FR1\",\"CDR1\",\"FR2\",\"CDR2\",\"FR3\",\"FR4\",\"VDJRegion\"]as theimputedlist and[\"CDR3\"]asnonImputedfor CDR3 assembly.exportSpecs.test.ts): TypeScript mirror of the Tengo logic with a new test asserting the corrected CDR3 imputed/nonImputed split.--registry-serve-urlto the publish script.Confidence Score: 4/5
Safe to merge. The change is targeted and correct: the CDR3 imputed/nonImputed lists are now logically consistent with how CDR3 amplicon sequencing works, and all existing guard conditions remain correct.
The behavioral change to nonImputed for CDR3 means users who ran CDR3 assembly without imputation will no longer see FR1/CDR1/FR2/etc. columns in their output — a silent schema change for existing pipelines. No test exercises the full Tengo runtime for CDR3+imputeGermline=true end-to-end.
workflow/src/calculate-export-specs.lib.tengo carries the core behavioral change and would benefit from an integration-level snapshot test for assemblingFeature=CDR3 with imputeGermline=true.
Important Files Changed
Reviews (1): Last reviewed commit: "Fix imputeGermline having no effect when..." | Re-trigger Greptile