Skip to content

Switch to retentive outputs - #45

Closed
mzueva wants to merge 1 commit into
mainfrom
mzueva/use-retentive-outputs
Closed

Switch to retentive outputs#45
mzueva wants to merge 1 commit into
mainfrom
mzueva/use-retentive-outputs

Conversation

@mzueva

@mzueva mzueva commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @mzueva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the output handling mechanism within the application's core model. By switching to 'retentive outputs', the system is now configured to persist or retain the state of specific data outputs more effectively, ensuring their availability across different operations or contexts. This modification enhances the robustness of data flow within the model.

Highlights

  • Output Mechanism Update: The outputWithStatus method has been replaced with retentiveOutputWithStatus for both 'pt' and 'pf' outputs within the BlockModel definition in model/src/index.ts. This change likely affects how these specific outputs manage and retain their state.
  • Changelog Entry: A new changeset file, .changeset/witty-ravens-smile.md, has been added to document this change, indicating a patch release for @platforma-open/milaboratories.repertoire-diversity-2.model.
Changelog
  • .changeset/witty-ravens-smile.md
    • Added a new changeset file to document the switch to retentive outputs.
  • model/src/index.ts
    • Replaced outputWithStatus with retentiveOutputWithStatus for 'pt' and 'pf' outputs.
Activity
  • No human activity (comments, reviews, or approvals) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request switches two outputs, pt and pf, to be retentive. While the change itself is simple, my review found that both of these outputs have significant pre-existing bugs. The pf output has a circular dependency on itself which will cause a stack overflow. The pt output depends on pf and also appears to use incorrect arguments for createPlDataTableV2. I've added comments with high and critical severity to address these issues, which should be fixed to ensure the block functions correctly.

@mzueva mzueva closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant