Rework Valkey to pull from registry.json #5100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Upsun Fixed environment has successfully deployed. 🚀 See the changed pages: Upsun Fixed docs |
gilzow
requested changes
Oct 20, 2025
Co-authored-by: Paul Gilzow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #4851
When Valkey was initially added, it was not added in the normal way we add a new service. As such, it is missing from areas like https://docs.platform.sh/add-services.html#available-services.
We need to add it to shared/data/registry.json and rework associated valkey pages to work similar to other services, vs static information.
What's changed
Where are changes
shared/data/registry.json
https://fixed.docs.upsun.com/add-services/valkey.html
Valkey now shows up in https://fixed.docs.upsun.com/add-services.html#available-services
https://docs.upsun.com/add-services/valkey.html
Valkey now shows up in https://docs.upsun.com/add-services.html#available-services
Updates are for:
sites/platformtemplates)sites/upsuntemplates)