feat(dome): Adding Skydome as option for skybox#143
Open
marcteys wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's quite useful to allow user to load skydome. It is particularly relevant when loading cleaned-up grounded objects ( example a building without it's context).
Summary
Unifies skybox/skydome configuration under
background.skybox, adds dome projection support, and refreshes the example with v2 settings and a default orbit anim track.Changes
skydomeUrlwith a singlebackground.skyboxobject (url,projection,scale,center) in the v2 schema.skyprojectionquery param and keptskydomeas a backwards‑compatible alias.DomeGeometrymesh (background‑only) and expanded camera far clip when a dome is present.center, no camera‑follow).example/settings.jsonto v2 and included a looping orbit anim track for a better out‑of‑box demo.You can test this PR with the example here: https://github.com/preserve-archi/supersplat-viewer-skyDomeExample