Skip to content

Make camera info values editable and initialize publish loop mode from the timeline#953

Merged
slimbuck merged 2 commits into
playcanvas:mainfrom
slimbuck:fixes
Jul 8, 2026
Merged

Make camera info values editable and initialize publish loop mode from the timeline#953
slimbuck merged 2 commits into
playcanvas:mainfrom
slimbuck:fixes

Conversation

@slimbuck

@slimbuck slimbuck commented Jul 8, 2026

Copy link
Copy Markdown
Member

Camera info overlay

  • Position and target values are now directly editable: click a value, type new coordinates (commas or spaces both parse), Enter or clicking away applies, Escape cancels, and invalid input flashes red. Editing the position keeps the current target and vice versa. This replaces the previous click-to-copy behavior.
  • Rows are labelled with bold orange P / T letters, and hovering anywhere on a row shows a localized "Camera Position" / "Camera Target" tooltip.
  • Values render in monospace with tabular numerals and simplified formatting — trailing zeros are dropped (0.000, 0.500.5) and -0.00 can no longer appear.
  • The live per-frame refresh skips a row while it is being edited, and key events no longer reach editor shortcuts while typing.
  • Fixed the text shadow being clipped at label bounds (pcui labels default to overflow: hidden).
  • Removed the old focal-point cursor label from the bottom-left corner — the overlay's target row shows the same information live — along with its now-unused locale keys.

Publish settings

  • The publish dialog's animation loop mode now initializes from the editor timeline's loop toggle (repeat when looping, none otherwise) instead of always defaulting to repeat.

@slimbuck slimbuck requested a review from Copilot July 8, 2026 14:07
@slimbuck slimbuck self-assigned this Jul 8, 2026
@slimbuck slimbuck added the enhancement New feature label Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the editor UI to make the camera info overlay interactive (directly editable position/target with improved formatting and tooltips) and aligns the publish dialog’s animation loop mode default with the timeline’s current loop toggle.

Changes:

  • Reworks the camera info overlay to allow in-place editing of camera position/target, with validation feedback and per-frame updates paused while editing.
  • Removes the old bottom-left “cursor label” copy-to-clipboard UI and its now-unused localization keys.
  • Initializes publish animation loop mode from timeline.loop instead of always defaulting to repeat.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
static/locales/en.json Updates camera overlay strings and removes unused cursor copy strings.
static/locales/de.json Same localization updates (German).
static/locales/es.json Same localization updates (Spanish).
static/locales/fr.json Same localization updates (French).
static/locales/ja.json Same localization updates (Japanese).
static/locales/ko.json Same localization updates (Korean).
static/locales/pt-BR.json Same localization updates (Portuguese - Brazil).
static/locales/ru.json Same localization updates (Russian).
static/locales/zh-CN.json Same localization updates (Chinese - Simplified).
src/ui/scss/style.scss Removes cursor-label styling and updates camera info overlay styling for editable/flash states.
src/ui/editor.ts Removes cursor label UI wiring and associated tooltip registration.
src/ui/camera-info-overlay.ts Implements editable camera position/target rows, parsing/formatting, tooltips, and edit-state handling.
src/ui/publish-settings-dialog.ts Sets publish loop mode from events.invoke('timeline.loop').

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@slimbuck slimbuck marked this pull request as ready for review July 8, 2026 14:40
@slimbuck slimbuck requested a review from a team July 8, 2026 14:41
@slimbuck slimbuck merged commit 3cc020c into playcanvas:main Jul 8, 2026
2 checks passed
@slimbuck slimbuck deleted the fixes branch July 8, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants