Make camera info values editable and initialize publish loop mode from the timeline#953
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the editor UI to make the camera info overlay interactive (directly editable position/target with improved formatting and tooltips) and aligns the publish dialog’s animation loop mode default with the timeline’s current loop toggle.
Changes:
- Reworks the camera info overlay to allow in-place editing of camera position/target, with validation feedback and per-frame updates paused while editing.
- Removes the old bottom-left “cursor label” copy-to-clipboard UI and its now-unused localization keys.
- Initializes publish animation loop mode from
timeline.loopinstead of always defaulting torepeat.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| static/locales/en.json | Updates camera overlay strings and removes unused cursor copy strings. |
| static/locales/de.json | Same localization updates (German). |
| static/locales/es.json | Same localization updates (Spanish). |
| static/locales/fr.json | Same localization updates (French). |
| static/locales/ja.json | Same localization updates (Japanese). |
| static/locales/ko.json | Same localization updates (Korean). |
| static/locales/pt-BR.json | Same localization updates (Portuguese - Brazil). |
| static/locales/ru.json | Same localization updates (Russian). |
| static/locales/zh-CN.json | Same localization updates (Chinese - Simplified). |
| src/ui/scss/style.scss | Removes cursor-label styling and updates camera info overlay styling for editable/flash states. |
| src/ui/editor.ts | Removes cursor label UI wiring and associated tooltip registration. |
| src/ui/camera-info-overlay.ts | Implements editable camera position/target rows, parsing/formatting, tooltips, and edit-state handling. |
| src/ui/publish-settings-dialog.ts | Sets publish loop mode from events.invoke('timeline.loop'). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Camera info overlay
P/Tletters, and hovering anywhere on a row shows a localized "Camera Position" / "Camera Target" tooltip.0.00→0,0.50→0.5) and-0.00can no longer appear.overflow: hidden).Publish settings
repeatwhen looping,noneotherwise) instead of always defaulting torepeat.