clear registry when transitioning to non view state#564
Draft
clear registry when transitioning to non view state#564
Conversation
Contributor
Author
|
/canary |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 89.70% 89.70%
=======================================
Files 331 331
Lines 19794 19804 +10
Branches 1948 1949 +1
=======================================
+ Hits 17756 17766 +10
Misses 2024 2024
Partials 14 14 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When going from a view state to an external state to another view state, the content from first view shows momentarily before showing content of new view state, by resetting the view we prevent this from happening
similar behaviour occurs when a view going to an END state and shows a modal and previous view is still present before showing new content
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
📦 Published PR as canary version:
0.10.1--canary.564.18899Try this version out locally by upgrading relevant packages to 0.10.1--canary.564.18899