catch runtime released exceptions from lifecycle callbacks#764
Open
catch runtime released exceptions from lifecycle callbacks#764
Conversation
brocollie08
reviewed
Nov 25, 2025
| is Error -> onError(it) | ||
| is Done -> onDone(it) | ||
| } | ||
| } catch (exception: PlayerRuntimeException) { |
Contributor
There was a problem hiding this comment.
Can we make that exception "special" and catch only that, instead of all PlayerRuntimeExceptions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
=======================================
Coverage 85.77% 85.77%
=======================================
Files 504 504
Lines 22679 22679
Branches 2651 2651
=======================================
Hits 19454 19454
Misses 2896 2896
Partials 329 329 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
ManagedPlayercallbacks are invoked automatically withinPlayerFragment, we should catch runtime released exceptions to protect against app crashes. We would ideally log, but we don't have an active logger yet that isn't dependent upon the runtimeChange Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?