feat: add number_of_employees field to Profile API - #246
Draft
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Draft
feat: add number_of_employees field to Profile API#246Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Conversation
Add optional NumberOfEmployees field (json: number_of_employees) to the Profile create/update request params and the Profile response struct, mirroring the campaign-service backend change. No client-side enum validation; allowed values documented in a comment. Updated tests, fixtures, CHANGELOG, and bumped sdkVersion to 7.60.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new optional
number_of_employeesfield to the Profile (10DLC/A2P) API in the plivo-go SDK, mirroring the campaign-service backend change where it was added to the Profile create & update request as an optional string.Follows the exact same pattern as the recently added
doing_business_as(DBA) field.Changes
profile.go: AddedNumberOfEmployees string(jsonnumber_of_employees,omitempty) right afterDoingBusinessAsinCreateProfileRequestParams,UpdateProfileRequestParams, and theProfileresponse struct.DoingBusinessAs/BusinessContactEmail. The 7 allowed values are documented in a code comment.profile_test.go: SetNumberOfEmployeesin Create/Update test params and added a Get assertion, mirroring DBA.fixtures/profileGetResponse.json: Addednumber_of_employeesto the fixture.CHANGELOG.md: New entry at top (2026-06-10).baseclient.go: BumpedsdkVersion7.60.1 -> 7.60.2.Allowed values (server-validated, documented only)
BETWEEN_1_AND_10,BETWEEN_11_AND_50,BETWEEN_51_AND_200,BETWEEN_201_AND_500,BETWEEN_501_AND_2000,BETWEEN_2001_AND_10000,MORE_THAN_10001Verification
go build ./...passesgo test -run TestProfile ./...passesgofmt -lclean on all changed files🤖 Generated with Claude Code