Skip to content

Handled for allowing to upload multiple files #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Narayana Shanbhog Plivo (narayana-plivo) wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handled for allowing to upload multiple files #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d40f02
multiple file upload media fix
narayana-plivo Mar 18, 2020
735667d
multiple file upload allowed
narayana-plivo Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Change Log
## [4.1.7](https://github.com/plivo/plivo-go/tree/v4.1.7) (2020-03-18)
- Fix for mulitple file media upload

## [4.1.6](https://github.com/plivo/plivo-go/tree/v4.1.6) (2020-02-25)
- Add Media support

Expand Down
2 changes: 1 addition & 1 deletion baseclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/google/go-querystring/query"
)

const sdkVersion = "4.1.6"
const sdkVersion = "4.1.7"

type ClientOptions struct {
HttpClient *http.Client
Expand Down
8 changes: 4 additions & 4 deletions media.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ func (service *MediaService) Upload(params MediaUpload) (response *MediaResponse
if errFile1 != nil {
return nil, errFile1
}
filerror := writer.Close()
if filerror != nil {
return nil, filerror
}
}
filerror := writer.Close()
if filerror != nil {
return nil, filerror
}
requestUrl := service.client.BaseUrl
requestUrl.Path = fmt.Sprintf(baseRequestString, fmt.Sprintf(service.client.AuthId+"/Media"))
Expand Down