Revert CallCreateResponse.RequestUUID data type change - #91
Open
Omar Elgabry (OmarElgabry) wants to merge 1 commit into
Open
Revert CallCreateResponse.RequestUUID data type change#91Omar Elgabry (OmarElgabry) wants to merge 1 commit into
Omar Elgabry (OmarElgabry) wants to merge 1 commit into
Conversation
Reverted changes introduced here plivo#77 (string to inerface{} type)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like this has been changed from "string" to "interface{}" in this PR: https://github.com/plivo/plivo-go/pull/77/files#diff-ad3ebf6fd77d67a722e314a5c522bbf92c0be506e5eb23fadfd2358de63c08b9R95
Can someone clarify where in the Plivo docs do they mention
RequestUUIDis not always a string?. Or, in other words, why it was changed to "interface{}" from a string when it is always a string?.Docs: https://www.plivo.com/docs/voice/api/call#make-a-call
CC: varshit97plivo