feat: add number_of_employees field to Profile API - #373
Draft
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Draft
feat: add number_of_employees field to Profile API#373Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Conversation
Add an optional number_of_employees string field to the Profile create and update APIs, mirroring the existing doing_business_as (DBA) field. The server validates the value; the SDK documents the 7 allowed values without enforcing them. Bumps patch version to 4.69.3 and updates the changelog and tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
number_of_employeesstring field to the Profile (10DLC/A2P account profile) create & update APIs. This mirrors a backend change in campaign-service wherenumber_of_employeeswas added to the Profile create/update request as an optional string.The implementation follows the recently added
doing_business_as(DBA) field exactly — same files, same positions (immediately after DBA), same style.Changes
src/Plivo/Resources/Profile/ProfileInterface.php: added$number_of_employees = ''param tocreate()(after$doing_business_as), conditional inclusion into the request args, and documented the 7 allowed values in thecreate()/update()docblocks. No client-side enum validation (server validates).tests/Resources/ProfileTest.php: addednumber_of_employeesto the expected request payload and thecreate()call args, mirroring DBA.src/Plivo/Version.php: patch bump4.69.2→4.69.3.CHANGELOG.md: new4.69.3entry dated 2026-06-10.Allowed values (documented, not enforced)
BETWEEN_1_AND_10,BETWEEN_11_AND_50,BETWEEN_51_AND_200,BETWEEN_201_AND_500,BETWEEN_501_AND_2000,BETWEEN_2001_AND_10000,MORE_THAN_10001🤖 Generated with Claude Code