Skip to content

Updated make acceptance test cookieplone-template make commands descriptions #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevepiercy merged 4 commits into from
Jan 12, 2026
Merged

Updated make acceptance test cookieplone-template make commands descriptions #2017

stevepiercy merged 4 commits into from
Jan 12, 2026

Conversation

@boss6825
Copy link
Member

@boss6825 boss6825 commented Dec 22, 2025 •
edited by stevepiercy
Loading

Fixes #1943

Description

Added a missing section for acceptance commands in cookieplone-template make commands description

This PR is in accordance with plone/cookieplone-templates#323
In plone/cookieplone-templates#323 , I have removed the -dev from acceptance-backend-dev-start.
So I have did the same for documentation also, As the issues for these PRs were inter-related.

📚 Documentation preview 📚: https://plone6--2017.org.readthedocs.build/

@boss6825
Copy link
Member Author

boss6825 commented Dec 22, 2025

Should i turn this PR into a Draft PR?
The PR which is related to it that is plone/cookieplone-templates#323 has not been merged yet.

@stevepiercy
Copy link
Contributor

stevepiercy commented Dec 24, 2025

@boss6825 good idea. Yes, please.

@boss6825 boss6825 marked this pull request as draft December 24, 2025 10:20
@stevepiercy
Copy link
Contributor

stevepiercy commented Jan 11, 2026

plone/cookieplone-templates#323 has been merged.

@stevepiercy stevepiercy marked this pull request as ready for review January 11, 2026 22:44
@stevepiercy stevepiercy moved this from New to In Progress in Plone Documentation Jan 11, 2026
@stevepiercy
Copy link
Contributor

stevepiercy commented Jan 11, 2026

I'll review this tonight.

stevepiercy
stevepiercy requested changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I especially like how you left out tedious implementation details for each the backend and frontend images, when a single command is best.

Just a minor heading change and addition of {file} MyST markup, and this can be merged. I'll make thes changes and merge it. Thank you!

@stevepiercy stevepiercy enabled auto-merge (squash) January 12, 2026 10:49
@stevepiercy stevepiercy added this to the Plone 6.2 milestone Jan 12, 2026
@stevepiercy stevepiercy disabled auto-merge January 12, 2026 10:59
@boss6825
Copy link
Member Author

boss6825 commented Jan 12, 2026

Excellent work! I especially like how you left out tedious implementation details for each the backend and frontend images, when a single command is best.

Just a minor heading change and addition of {file} MyST markup, and this can be merged. I'll make thes changes and merge it. Thank you!

Happy to help 😊

@stevepiercy stevepiercy merged commit 28781d7 into plone:6.0 Jan 12, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Plone Documentation Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees

No one assigned

Labels

None yet

Projects

Plone Documentation
Status: Done

Milestone

Plone 6.2

Development

Successfully merging this pull request may close these issues.

Update make acceptance test cookieplone-template make commands descriptions

2 participants

@boss6825 @stevepiercy