feat: create reCAPTCHA validation utility#1204
Open
rboixaderg wants to merge 6 commits intomasterfrom
Open
Conversation
rboixaderg
requested review from
bloodbare,
masipcat and
vangheem
as code owners
There was a problem hiding this comment.
Pull request overview
This PR refactors reCAPTCHA validation by converting it from a directly instantiated class to a proper utility pattern using the existing IAsyncUtility interface framework. This follows the established patterns in the codebase for utilities like cache, queue, and session management.
Key Changes
- Created
IRecaptchaValidationUtilityinterface extendingIAsyncUtilityfor standardized reCAPTCHA validation - Refactored three endpoints (
@login,@register,@info-access) to use the new utility pattern viaget_utility()instead of direct instantiation - Added optional validation checks that gracefully handle cases where the utility is not configured
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| guillotina/interfaces/async_util.py | Defines the new IRecaptchaValidationUtility interface with a validate() method |
| guillotina/interfaces/init.py | Exports the new interface for external use |
| guillotina/auth/init.py | Removes direct export of RecaptchaValidator class |
| guillotina/api/login.py | Updates three endpoints to use utility pattern with optional validation via get_utility() |
| guillotina/_settings.py | Registers the reCAPTCHA validator as a loadable utility in default settings |
| CHANGELOG.rst | Documents the feature addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bloodbare
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.