Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uv #147

Open
wants to merge 1 commit into
base: 6.0.x
Choose a base branch
from
Open

use uv #147

wants to merge 1 commit into from

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested a review from ericof July 17, 2024 14:20
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this is not an entirely backwards-compatible change; there are edge cases where uv does not do everything the same as pip: https://github.com/astral-sh/uv/blob/main/PIP_COMPATIBILITY.md

I would save this for 6.1 at least

@davisagli
Copy link
Member

Now I'm thinking we should make this available as a separate image (plone-backend-uv?) -- sort of like we plan to do for yarn vs pnpm for the frontend.

Also I just found this article with some helpful suggestions. https://hynek.me/articles/docker-uv/

@fredvd
Copy link
Member

fredvd commented Feb 6, 2025

@davisagli @sneridagh Seems to be something we can add to the 6.1.0 images now. Do we have a more clear view on the edge cases that David mentionned in this issue last year?

@davisagli
Copy link
Member

davisagli commented Feb 6, 2025

@fredvd this is something we should do in the first alpha image for a new release series, not in between an rc and final :)

Edited to add: I mean if we switch to it as the default. Certainly we can experiment with adding a 2nd image option now.

@fredvd
Copy link
Member

fredvd commented Feb 6, 2025

Yes I realise this is rather/too late. But this tension os a consequence of keeping the main Plone version equal with the container image versions, having limited resources in the community, and looking at the ‘installer’ when the KGS of the sources are RC.

Maybe we can re-use the variant strategy used for frontend yarn/npm and the -bookworm update for the 6.0 plone-backend series with more recent OS and Python version.

We can add UV and other ‘professional experiments’ to a 6.1-next series of images where we can collaboratively work on improving the images in a public way. Then when Plone 6.2 is a about to be released, the ecosystem tested and refined in the 6.1-next images can be made the ‘stable’ main basis for the 6.2 images.

I’ll copy this to a new issue as well to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants