Move built-in vocabulary permissions to plone.app.vocabulary #237
Conversation
|
@ksuess thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
ksuess
changed the title
There was a problem hiding this comment.
So this belongs together with plone/plone.app.vocabularies#67.
On the one hand it makes sense to move these permission definitions to where the vocabularies are. On the other hand plone.app.vocabularies does not use these permissions. So I am on the fence on this one.
I can imagine though that plone.restapi may want to use these permissions as well.
One of the permissions defined here is for plone.app.multilingual, although it could be removed from the list because it is the same as the DEFAULT_PERMISSION.
@jensens Do you want to comment?
…T_PERMISSION_SECURE', 'PERMISSIONS' from plone.app.vocabularies
mauritsvanrees
force-pushed
the
move-vocab-permissions-to-p.a.vocabularies
branch
from
00ac441 to
bf36d19
Compare
|
I would put permissions to the domain they are in, vocabularies to pa.vocabularies and multilingual to pam. |
Companion of plone/plone.app.vocabularies#67