Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bad input as BadRequest instead of ValueError #1855

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Handle bad input as BadRequest instead of ValueError #1855

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ffc42c4
Handle bad input as BadRequest instead of ValueError
djay Jan 13, 2025
26a8b7a
added basic test
djay Jan 14, 2025
bc924b3
Update src/plone/restapi/services/navigation/get.py
djay Jan 14, 2025
2ea94ce
Merge branch 'djay-handle-badrequests' of https://github.com/plone/pl…
djay Jan 14, 2025
4fb0e7b
batching int valueerror to badrequests
djay Jan 14, 2025
30b8039
fix flake8
djay Jan 14, 2025
3a4fbd1
add changelog
djay Jan 14, 2025
03d8487
Update news/1855.bugfix
davisagli Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/plone/restapi/services/navigation/get.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from zope.i18n import translate
from zope.interface import implementer
from zope.interface import Interface
from zExceptions import BadRequest


@implementer(IExpandableElement)
Expand All @@ -29,7 +30,10 @@ def __init__(self, context, request):

def __call__(self, expand=False):
if self.request.form.get("expand.navigation.depth", False):
self.depth = int(self.request.form["expand.navigation.depth"])
try:
self.depth = int(self.request.form["expand.navigation.depth"])
except ValueError as e:
djay marked this conversation as resolved.
Show resolved Hide resolved
raise BadRequest(e)
djay marked this conversation as resolved.
Show resolved Hide resolved
else:
self.depth = 1

Expand Down
Loading