Skip to content

fix(a11y): FileWidget and RegistryImageWidget a11y improvements - backport - #8320

Merged
Wagner3UB merged 18 commits into
18.x.xfrom
file-and-image-widget-a11y-v18
Jul 14, 2026
Merged

fix(a11y): FileWidget and RegistryImageWidget a11y improvements - backport#8320
Wagner3UB merged 18 commits into
18.x.xfrom
file-and-image-widget-a11y-v18

Conversation

@Wagner3UB

Copy link
Copy Markdown
Contributor

Backport of #7982 from Volto 19 to Volto 18, with an additional fix for the screen reader announcement when a file is already present.

Changes

  • FileWidget: added role="button", aria-labelledby, and aria-describedby to the dropzone container for proper keyboard and screen reader support
  • FileWidget: label is now aria-hidden with stopPropagation on click to prevent double file dialog opening
  • FileWidget: hidden status span announces upload instructions, required state, and current filename to screen readers
  • FileWidget: distinguishes between "open file browser" and "replace existing file" in the screen reader announcement depending on whether a file is already uploaded (improvement over the original v19 PR)
  • FileWidget: aria-required and aria-invalid added to the file input
  • FileWidget: download link now has a descriptive aria-label with the filename
  • FileWidget: new fieldSet prop to correctly build the aria-labelledby reference
  • RegistryImageWidget: updated editFile message to match new wording
  • main.less: added padding-bottom: 1rem to .file-widget-dropzone
  • locales: translated all new/updated strings across 65 languages

@Wagner3UB
Wagner3UB requested review from stevepiercy and wesleybl June 9, 2026 14:49
@Wagner3UB
Wagner3UB requested a review from a team June 9, 2026 15:08

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sprinkling of MyST markup, and a concern to address.

This needs a technical review as well.

Comment thread packages/volto/news/8320.bugfix Outdated
Comment thread packages/volto/locales/volto.pot Outdated
Comment thread packages/volto/src/components/manage/Widgets/FileWidget.jsx Outdated
Wagner3UB and others added 2 commits June 10, 2026 09:18
@github-project-automation github-project-automation Bot moved this to In progress in Accessibility Jun 10, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Review in progress in Accessibility Jun 10, 2026

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! msgids preserved. LGTM. Thank you!

@github-project-automation github-project-automation Bot moved this from Review in progress to Reviewer approved in Accessibility Jun 11, 2026

@wesleybl wesleybl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the text has changed since the PR on the main branch. I think that, for consistency and to facilitate future backports, the text should be the same. If that's the case, we need to update the text on the main branch.

@github-project-automation github-project-automation Bot moved this from Reviewer approved to Review in progress in Accessibility Jun 13, 2026
@Wagner3UB

Copy link
Copy Markdown
Contributor Author

I noticed that the text has changed since the PR on the main branch. I think that, for consistency and to facilitate future backports, the text should be the same. If that's the case, we need to update the text on the main branch.

@wesleybl You are right. But the problem isn't here, its in the 19 version: #8334

@Wagner3UB Wagner3UB self-assigned this Jun 15, 2026
@Wagner3UB

Copy link
Copy Markdown
Contributor Author

I noticed that the text has changed since the PR on the main branch. I think that, for consistency and to facilitate future backports, the text should be the same. If that's the case, we need to update the text on the main branch.

@wesleybl Here we are good to go. I did a fix on the main PR to be like this one. We can continue.

@github-project-automation github-project-automation Bot moved this from Review in progress to Reviewer approved in Accessibility Jul 13, 2026
@Wagner3UB
Wagner3UB merged commit ca455ee into 18.x.x Jul 14, 2026
59 of 60 checks passed
@Wagner3UB
Wagner3UB deleted the file-and-image-widget-a11y-v18 branch July 14, 2026 09:41
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Accessibility Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants