fix(a11y): FileWidget and RegistryImageWidget a11y improvements - backport - #8320
Conversation
Documentation build overview
106 files changed ·
|
stevepiercy
left a comment
There was a problem hiding this comment.
A sprinkling of MyST markup, and a concern to address.
This needs a technical review as well.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
left a comment
There was a problem hiding this comment.
Yay! msgids preserved. LGTM. Thank you!
wesleybl
left a comment
There was a problem hiding this comment.
I noticed that the text has changed since the PR on the main branch. I think that, for consistency and to facilitate future backports, the text should be the same. If that's the case, we need to update the text on the main branch.
@wesleybl You are right. But the problem isn't here, its in the 19 version: #8334 |
@wesleybl Here we are good to go. I did a fix on the main PR to be like this one. We can continue. |
Backport of #7982 from Volto 19 to Volto 18, with an additional fix for the screen reader announcement when a file is already present.
Changes
role="button",aria-labelledby, andaria-describedbyto the dropzone container for proper keyboard and screen reader supportaria-hiddenwithstopPropagationon click to prevent double file dialog openingaria-requiredandaria-invalidadded to the file inputaria-labelwith the filenamefieldSetprop to correctly build thearia-labelledbyreferenceeditFilemessage to match new wordingpadding-bottom: 1remto.file-widget-dropzone