Andrew/dimensions checks + PDF Fix #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayjayt
commented
Mar 12, 2025
| @@ -361,7 +361,7 @@ async def _img_from_response(self, response): | |||
| "marginBottom": 0.1, | |||
| "marginLeft": 0.1, | |||
| "marginRight": 0.1, | |||
| "preferCSSPageSize": False, | |||
| "preferCSSPageSize": True, | |||
emilykl
approved these changes
Mar 13, 2025
|
@ayjayt Are there any blockers to merging this PR? It'll be easier for me to do end-to-end testing in Plotly.py once this is merged. |
|
Not to my knowledge, but since today is a holiday, I can review them tomorrow morning. I'd only be checking the CHANGELOG to make sure its accurate to the incoming version number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things in this PR:
New Mocker Functions
_mocker.pyit adds arguments for printing out the mock w/ parameterized width/scale/heightExample
$ uv run kaleido_mocker --parameterize_opts --output . --random 5 --n 15the parameters are hardcoded right now, but certain values can be fixed by setting
--[format, scale, width, height] VALUE. Otherwise, tons and tons of output. The command above, 5 mocks, 810 output files.Fix PDF page-size