Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change subpackage name #177

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion choreographer/DIR_INDEX.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ which has "Tabs".
Directories
-----------

_devtools_protocol_layer/
protocol/

The browser-tab interface is intuitive, but here we have the interface that Chrome's
Devtools Protocol actually provides.
Expand Down
2 changes: 1 addition & 1 deletion choreographer/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""choreographer is a browser controller for python."""

import choreographer._devtools_protocol_layer as protocol
from choreographer import protocol

from ._browser import Browser, BrowserClosedError, browser_which, get_browser_path
from ._cli_utils import get_browser, get_browser_sync
Expand Down
14 changes: 7 additions & 7 deletions choreographer/_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@
from pathlib import Path
from threading import Thread

from ._devtools_protocol_layer._protocol import (
from ._pipe import Pipe, PipeClosedError
from ._system_utils._system import browser_which
from ._system_utils._tempfile import TempDirectory, TempDirWarning
from ._tab import Tab
from .protocol._protocol import (
TARGET_NOT_FOUND,
DevtoolsProtocolError,
ExperimentalFeatureWarning,
Protocol,
)
from ._devtools_protocol_layer._session import Session
from ._devtools_protocol_layer._target import Target
from ._pipe import Pipe, PipeClosedError
from ._system_utils._system import browser_which
from ._system_utils._tempfile import TempDirectory, TempDirWarning
from ._tab import Tab
from .protocol._session import Session
from .protocol._target import Target

# importing the below via __file__ causes __name__ weirdness when its exe'd ???
chromewrapper_path = (
Expand Down
2 changes: 1 addition & 1 deletion choreographer/_tab.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from ._devtools_protocol_layer._target import Target
from .protocol._target import Target


class Tab(Target):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"""choreographer.protocol provides classes and tools for Chrome Devtools Protocol."""

from ._protocol import (
DevtoolsProtocolError,
ExperimentalFeatureWarning,
Expand Down
Loading