Skip to content

Fix pages modules is package #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T4rk1n merged 3 commits into from
May 29, 2025
Merged

Fix pages modules is package #3315

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f893f55
Fix pages is_module_package check
T4rk1n May 29, 2025
95c7826
testing on pull_request and push to dev,master
T4rk1n May 29, 2025
31db4cc
update changelog
T4rk1n May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: Dash Testing

on:
push:
branches:
- dev
- master
pull_request:
workflow_dispatch:

jobs:
Expand Down
10 changes: 4 additions & 6 deletions dash/_pages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,10 @@ def _infer_path(module_name, template):


def _module_name_is_package(module_name):
file_path = sys.modules[module_name].__file__
return (
file_path
and module_name in sys.modules
and Path(file_path).name == "__init__.py"
)
if module_name not in sys.modules:
return False
file = sys.modules[module_name].__file__
return file and file.endswith("__init__.py")
Copy link
Contributor

@gvwilson gvwilson May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this return empty string rather than a boolean?

Copy link
Contributor Author

@T4rk1n T4rk1n May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's usage is in a condition here:

dash/dash/_pages.py

Line 110 in f893f55

if _module_name_is_package(CONFIG.name):



def _path_to_module_name(path):
Expand Down
Loading