Skip to content

run async test in separate step & flaky cbsc001 #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T4rk1n merged 1 commit into from
Jun 27, 2025
Merged

run async test in separate step & flaky cbsc001 #3352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:
- 'dash/dash-renderer/**'
- 'dash/_callback.py'
- 'dash/_callback_context.py'
- 'tests/background_callback/**'
- 'tests/async_tests/**'
- 'requirements/**'

build:
Expand Down Expand Up @@ -263,6 +265,10 @@ jobs:
cd bgtests
touch __init__.py
pytest --headless --nopercyfinalize tests/background_callback -v -s

- name: Run Async Callback Tests
run: |
cd bgtests
pytest --headless --nopercyfinalize tests/async_tests -v -s

table-unit:
Expand Down
3 changes: 3 additions & 0 deletions tests/async_tests/test_async_callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import json
import time

import flaky

from multiprocessing import Lock, Value
import pytest

Expand All @@ -27,6 +29,7 @@
from tests.utils import is_dash_async


@flaky.flaky(max_runs=3)
Copy link
Contributor

@gvwilson gvwilson Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know flaky existed - nice catch.

def test_async_cbsc001_simple_callback(dash_duo):
if not is_dash_async():
return
Expand Down