Skip to content

Fix dcc.Graph backward compatibility with dash 2.0 #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T4rk1n merged 3 commits into from
Jul 30, 2025
Merged

Fix dcc.Graph backward compatibility with dash 2.0 #3379

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74f482c
Fix dcc.Graph backward compatibility with dash 2.0
T4rk1n Jul 29, 2025
a018fc9
fix graph
T4rk1n Jul 29, 2025
953fc54
update changelog
T4rk1n Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions components/dash-core-components/src/fragments/Graph.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ import {
import PropTypes from 'prop-types';
import {graphPropTypes, graphDefaultProps} from '../components/Graph.react';

import LoadingElement from '../utils/LoadingElement';

/* global Plotly:true */

import ResizeDetector from '../utils/ResizeDetector';
Expand Down Expand Up @@ -537,23 +535,32 @@ class PlotlyGraph extends Component {
}

render() {
const {className, id} = this.props;
const {className, id, loading_state} = this.props;
const style = this.getStyle();

let isLoading;
if (window.dash_component_api !== undefined) {
const ctx = window.dash_component_api.useDashContext();
isLoading = ctx.useLoading();
} else {
isLoading = loading_state && loading_state.is_loading;
}

return (
<LoadingElement
<div
id={id}
key={id}
className={className}
style={style}
ref={this.parentElement}
data-dash-is-loading={isLoading ? true : undefined}
>
<ResizeDetector
onResize={this.graphResize}
targets={[this.parentElement, this.gd]}
/>
<div ref={this.gd} style={{height: '100%', width: '100%'}} />
</LoadingElement>
</div>
);
}
}
Expand Down