-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multicategory Multilevel 2+ & Sorting Multicategory #6327
Open
richardnm-2
wants to merge
62
commits into
plotly:master
Choose a base branch
from
richardnm-2:PR
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,101
−3,617
Open
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
be5d16b
sorting single trace OK
richardnm-2 202e6de
n levels setconvert 1 trace OK
richardnm-2 3de9038
stacking 3 labels on x OK
richardnm-2 06b03ba
3 levels plotting, labels zoado
richardnm-2 0ff71a8
dynamic lavels vertical X OK
richardnm-2 c184cdc
vertical alignment x axis seems OK
richardnm-2 176f623
teste secondaryLabels
richardnm-2 66ff0ff
labels when not shared OK
richardnm-2 18064b7
labels repeating OK
richardnm-2 46ba0f1
labels object.keys
richardnm-2 1dc7c17
TODO DIVIDERS
richardnm-2 3cb80de
labels loop and reverse corrected
richardnm-2 95f8674
dividers with levels OK, print NOT OK
richardnm-2 62d629d
plot checkpoint
richardnm-2 b2761eb
divider depth OK, but not plotting 2nd line
richardnm-2 0aff254
dividers remove -> plot OK
richardnm-2 774d6e5
checkpoint plot axes OK
richardnm-2 78e7e9b
sorting inside ax.setupMultiCategory OK
richardnm-2 6a5b8b0
console log cleanup
richardnm-2 450b7aa
multiple tracces test 1
richardnm-2 39809ba
multiple traces OK
richardnm-2 b81dce1
teste boxplot
richardnm-2 3b7ec42
validação list NOT OK
richardnm-2 3d79506
slice cols before reversing - inplace reverse
richardnm-2 a4eca4f
vai
richardnm-2 3615690
teste 3levels OK
richardnm-2 a68819b
getLabelBox dynamic
richardnm-2 fbbcc9c
index 3 levels 2 pts test
richardnm-2 3ec2f0b
Merge branch 'master' of https://github.com/richardnm-2/plotly.js
richardnm-2 630d00a
.vscode debugger OK
richardnm-2 36efc91
square matrix before transpose
richardnm-2 d57f5f0
codepen cleanup
richardnm-2 64561e7
hover text OK
richardnm-2 76ef318
pre minify cleanup
richardnm-2 e03e17e
hover text fix
richardnm-2 bc3358f
solved dividers remove
richardnm-2 dc94e50
pr OK
richardnm-2 7550011
hover text trim
richardnm-2 1b5748f
hovertext fix
richardnm-2 817a4a5
replicating on index
richardnm-2 7c8506c
heatmap test OK - yaxis questionable
richardnm-2 3925975
hover labe test OK - todo candlestick y axis multicategory
richardnm-2 c6e1690
Merge branch 'PR' of https://github.com/richardnm-2/plotly.js into PR
richardnm-2 fafd82b
debugger cleanup
richardnm-2 75e927f
lint
richardnm-2 34f23e6
Merge branch 'PR' of https://github.com/richardnm-2/plotly.js into PR
richardnm-2 49047b4
.at not supported
richardnm-2 25016f2
no valLetter (no y) -> nullArray
richardnm-2 60360ea
remove null from axis array trace OK
richardnm-2 059343f
sorting typed arrays OK
richardnm-2 46332a9
lint
richardnm-2 05ebb13
hover texts categories undefined resolved
richardnm-2 595de82
tick level rename
richardnm-2 68a2305
assert axLettter in trace
richardnm-2 2d33da3
axLetter y & valLetter x
richardnm-2 0135ec7
lock
richardnm-2 76ebc0c
Add .circleci/config.yml
richardnm-2 60ae004
Merge remote-tracking branch 'upstream/master' into circleci-project-…
b21f685
.
656bfb8
multicategory testing log
0475265
Merge branch 'circleci-project-setup' into PR
e67b25e
.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
debugger cleanup
commit fafd82b4cc9cf95044beeb39d4537dd5dbadb22b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my previous comment about adding things to
ax
, we can't be overwriting contents ofgd._fullData
in a way that conflicts with the contents ofgd.data
, but if necessary we can add underscore-prefixed attributes.Also: this section looks a bit too tightly coupled with concerns that belong to individual trace types. If we need to have logic here that's specific to one or two trace types, that functionality should go in the trace module and get called from there, something like:
Then
candlestick
andohlc
would opt into this behavior by defining asetupMultiCategory
function in their index files