Add support for xref/yref paper for shapes with layer "between" #6989
Conversation
Previously, it fell back to "below" for paper refs
archmoj
added
feature
there are now always 2 cartesian subplots where there was 1 before (one for background and one for foreground)
…r gridlayer Gridlayer is now in cartesianlayer-below, so it is below xaxislayer-above anyways.
|
@archmoj I finally fixed all failing tests except for baselines. Could you have a look again? :) |
…efined, plotgroup]
…d and countSublotsForeground
|
Again, remaining failing tests are unrelated baseline images (I think). |
|
@archmoj Please let me know if there is anything else I should look into before the PR can be approved. |
|
Please fetch |
|
It looks like the differing baseline tests just have a few pixel changes. I had a closer look at bar_multiline_labels.png because the image diff there seemed to contain more changes. I have attached a diff of the SVG between master and this branch and at least to me it looks exactly as intended: |
|
Please resolve the conflicts in this PR. |
Conflicts:
src/plot_api/subroutines.js
src/plots/cartesian/index.js
test/jasmine/tests/splom_test.js
Conflicts have been resolved, now we are back to the same failing tests again. |
gvwilson
added
cs
…_layer_between # Conflicts: # src/plots/cartesian/index.js
For shapes.layer "between" feature, this branch changed plotinfo.plotgroup from one single layer to an array of 2 layers ("below" and "above").
The zorder feature conflicted with this section and was solved incorrectly in the merge commit, leading to 3 layers in the plotgroups with z indices ("below", "above without z", "above with z"). In makeSubplotLayerAbove, traces were drawn into plotgroup[1], effectively discarding the zorder information.
sploms have less layers.
|
The new layer order introduced in this PR would cause all backgrounds, gridlines, zerolines, etc. from all sublots to be drawn below all traces of all subplots. This behavior is normally only achieved by setting the |
Previously, a shape with layer "between" and xref/yref "paper" fell back to layer = "below".
To support paper refs, I split up the
cartesianLayerinto acartesianLayerBelow(where plot background and gridlines are drawn) andcartesianLayerAbove(where the rest is drawn). Between the two is a newlayerBetween.Disclaimer
I am required to add that…the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.