Add dummy 'wheel' event handler to enable scroll zoom on safari #7474
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilykl
force-pushed
the
safari-scroll-zoom
branch
from
68f04da to
06c3e7f
Compare
archmoj
reviewed
Jul 17, 2025
emilykl
force-pushed
the
safari-scroll-zoom
branch
from
8370097 to
e6618c6
Compare
archmoj
approved these changes
Jul 18, 2025
camdecoster
reviewed
Jul 18, 2025
Comment on lines
+68
to
+70
| if(typeof plotObj.addEventListener === 'function') { | ||
| plotObj.addEventListener("wheel", () => {}); | ||
| } |
There was a problem hiding this comment.
Why is the if block necessary? Can plotObj be undefined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7452