Skip to content

Use newer acorn version for building, to support newer JS syntax #7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Use newer acorn version for building, to support newer JS syntax #7478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,5 +178,10 @@
"transform-loader": "^0.2.4",
"true-case-path": "^2.2.1",
"virtual-webgl": "^1.0.6"
},
"overrides": {
"falafel": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we should propose a PR to falafel repository.
But the repository seems missing at https://github.com/substack/node-falafel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

npm ls falafel
plotly.js
├─┬ [email protected]
│ └── [email protected] deduped
├── [email protected] overridden
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected] deduped

This looks fine.

Also

npm run preversion

passes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I haven't been able to track down the falafel repository anywhere online.

Maybe we should switch away from falafel entirely?

A quick Google search brings up https://github.com/loilo/yufka as a possible replacement but it's not widely used at all.

"acorn": "^8.1.1"
}
}
}
}