Don't clobber the Notebook's require/requirejs/define instances #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great to me. Thanks 🍻 . I'll let @cldougl / @chriddyp / @theengineear give this a final review. |
✔️ |
|
Excellent! Thanks! I'm good to merge, @chriddyp, sound good? |
|
looks good! |
chriddyp
added a commit
that referenced
this pull request
Feb 24, 2016
Don't clobber the Notebook's require/requirejs/define instances
This was referenced Mar 8, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to to clobber the require.js globals that live in the notebook for Plotly's offline mode. Nor does it make sense to load the Plotly JS from the CDN when running in offline mode. This PR uses requirejs named definitions and requirejs commonjs support to embed the plotly JS on the page.
This PR does not solve the workflow of getting the plotly.js build into the plotly.py repo. In a separate PR that should be automated.
related to #408
closes #373