Added recursivity for configuring moreoption by entity #3
+460
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Romain B. <[email protected]>
Co-authored-by: Romain B. <[email protected]>
|
Waiting #1 |
Rom1-B
requested changes
Oct 6, 2025
Co-authored-by: Romain B. <[email protected]>
Rom1-B
reviewed
Oct 7, 2025
src/Config.php
Outdated
| /** | ||
| * Get effective configuration for current entity, considering parent entity inheritance | ||
| */ | ||
| public static function getEffectiveConfig(): self |
There was a problem hiding this comment.
There are 3 similar functions: getCurrentConfig() (used only in tests), getEffectiveConfig(), and getEffectiveConfigForEntity(). One should be enough.
function getConfig(?int $entity_id = null): self
{
if ($entity_id === null) {
$entity_id = Session::getActiveEntity();
}
Rom1-B
reviewed
Oct 7, 2025
src/Config.php
Outdated
| /** | ||
| * Get effective configuration for current entity, considering parent entity inheritance | ||
| */ | ||
| public static function getEffectiveConfig(): self |
There was a problem hiding this comment.
I think we should do as the core does with: Entity::getUsedConfig()
Where it is not the entire entity that inherits from its parent, but each parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.