Conversation
bump
Greptile SummaryThis PR is a follow-up to #3394 ("Add plural chart to main repo"), adding the Confidence Score: 5/5Safe to merge — the functional fix (adding missing Helm repos) is correct and the only remaining finding is a P2 security hygiene suggestion. All changes are narrowly scoped: adding two Helm repo entries to unblock chart publishing and bumping the chart version. The sole finding (mutable No files require special attention.
|
| Filename | Overview |
|---|---|
| .github/workflows/chart.yaml | Adds ory and plural helm repos required for the new plural chart's dependencies (hydra, test-base); minor security concern with mikefarah/yq@master pinning. |
| charts/plural/Chart.yaml | Version bump to 0.10.108; chart metadata and dependencies look correct and align with the repos added in the workflow. |
Comments Outside Diff (1)
-
.github/workflows/chart.yaml, line 45 (link)Mutable
@masterreference formikefarah/yqPinning a GitHub Action to
@mastermeans any push to that branch silently changes the code executed in CI. If the upstream repo is compromised or accidentally broken, it will affect this workflow immediately. Pin to a specific released version tag or commit SHA instead.
Reviews (1): Last reviewed commit: "Another chart fix" | Re-trigger Greptile
bump
Test Plan
Checklist
Plural Flow: console