Repository navigation
fix(deps): enforce safe proxy-addr and shell-quote versions - #217
Conversation
There was a problem hiding this comment.
This PR was generated by the codex Plural Agent Runtime. Here's some useful information you might want to know to evaluate the ai's perfomance:
| Name | Details |
|---|---|
| 💬 Prompt | Remediate exactly the two critical npm Dependabot vulnerabilities in pluralsh/marketing and open one focused PR.... |
| 🔗 Run history | View run history |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
[Low impact] The changes affect dependency installation for this project’s development and build work. The PR appears safe for the current dependency tree, but it does not provide the promised protection against future dependency updates. Findings
SummaryAdds
Reviews (1) · Last reviewed commit: "fix(deps): lock safe proxy and shell pac..." · Reviewed by Greptile |
| "proxy-addr": "2.0.8", | ||
| "shell-quote": "1.11.0", |
There was a problem hiding this comment.
Old versions remain selectable
proxy-addr and shell-quote were added to devDependencies, not overrides. This pins only the root copies. A future dependency requiring proxy-addr@2.0.7 or shell-quote@1.9.0 can still install its own copy, so these additions do not provide the forward-looking protection described in the PR. Move the pins into overrides and regenerate package-lock.json.
There was a problem hiding this comment.
✅ Deploy preview for marketing-pr-217 is ready!
| Name | Details |
|---|---|
| ⚡ Service | marketing-pr-217 (5 / 5 ready) |
| ☁️ Cluster | plural (eks) |
| b2e3f6a | |
| https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a... | |
| 🔍 Logs URL | https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a... |
| 🌊 Flow URL | https://console.mgmt.plural.sh/flows/fbbadfa5-fa67-4c16-ab32-42dca133aa3... |
| Preview Link | Preview |
You can learn more about preview environments and Plural Flows here
Summary
proxy-addr@2.0.8andshell-quote@1.11.0.Fixes PROD-5322
Dependency paths
proxy-addr: no resolved parent path in the currentpackage-lock.json(no entry).shell-quote: no resolved parent path in the currentpackage-lock.json(no entry).2.0.7or1.9.0).Diff
package.json: add exact overrides only;package-lock.jsonwas regenerated with npm 11 and correctly required no update because neither target is resolved.Validation
node:26-alpine npm install --package-lock-only --ignore-scripts— passed.node:26-alpine npm ci— passed.proxy-addrorshell-quoteinstances.node:26-alpine npm run lint— passed.node:26-alpine npm run build— passed (compile, TypeScript, and static generation).Toolchain: Node 26.12.1 / npm 11.20.0 (project requires Node >=22).
Plural Flow: marketing
Plural Preview: marketing