Skip to content

Conversation

@raema
Copy link

@raema raema commented Sep 16, 2022

Starting this pull request as WIP for adding multi-tier cachelib example


This change is Reviewable

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk and @raema)


examples/M/README.txt line 5 at r1 (raw file):

This example is intended for C++ programmers.

This is example consists of these files:

drop is here


examples/M/README.txt line 7 at r1 (raw file):

This is example consists of these files:

main.cpp   -- ecample creating a mult-tier cache using pmem

FYI, misspell - ecample

@raema
Copy link
Author

raema commented Sep 23, 2022

Thanks @lukaszstolarczuk I fixed these typos

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@raema raema marked this pull request as ready for review October 4, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants