Automatically encode struct requests with encoding/xml#1
Open
pmh1wheel wants to merge 4 commits into
Open
Conversation
…marshaling Currently requires an explicit Request.UseXMLEncoder flag, but can probably automatically detect an XMLName field on the request object without breaking compatibility with requests which might trigger the Struct branch in recursiveEncode It's also a slightly uncomfortable mix of creating tokens for later encoding alongside encoding things directly, but the current interfaces make that hard to avoid Tests also still need a bit of work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves the struct handling alone in recursiveEncode, which is designed to deal with individual xml.Tokens.
Instead, we just use xml.Encode for top-level structs instead of diving into recursiveEncode, and leave the formatting up to the struct tags