fix: correct cron expression and update Node.js to v20#90
Merged
waldekmastykarz merged 1 commit intopnp:mainfrom Jan 15, 2026
Merged
Conversation
- Fix cron expression bug: use getUTCDate() for day and getUTCMonth()+1 for month - Update Node.js version from 18 to 20 in azure.bicep as 18 is no longer supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues in the nodejs-typescript-policies sample:
1. Fix cron expression bug in connections.ts
Before:
After:
The issue was:
getUTCMonth()returns 0-11, was incorrectly placed in the day positiongetUTCDay()returns day of week (0-6), was incorrectly placed in the month position{second} {minute} {hour} {day} {month} {day-of-week}2. Update Node.js version in azure.bicep
Updated
WEBSITE_NODE_DEFAULT_VERSIONfrom~18to~20since Node.js 18 is no longer supported.Testing