Allow to call Register-PnPEntraIDApp with a certificate without private key #5134
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the private key validation check when using an existing certificate with the Register-PnPAzureADApp cmdlet. The removed code ensured that certificates provided via the -CertificatePath parameter contain a private key before proceeding with app registration.
- Removes the
HasPrivateKeyvalidation check for certificates loaded from a file path - Eliminates the associated error message that would inform users when their certificate lacks a private key
|
Hey thanks @jackpoz, Merged it. //Nish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #5129
What is in this Pull Request ?
Allow to call Register-PnPEntraIDApp with a certificate without private key, so .cer instead of .pfx .
The private key is not needed when uploading a certificate to an app registration in Entra ID.
Here's the behavior with the PR:
The app registration works fine, see below a test case (notice how the pfx is used in this case with Connect-PnPOnline) :
