Skip to content

[FilePicker] Golbal quill styles from FilePicker overwrite other quill editors #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ffischer06 opened this issue May 13, 2025 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@ffischer06
Copy link

ffischer06 commented May 13, 2025

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.21.0 ]

Expected / Desired Behavior / Question

When using the filepicker i would expect the quill styling to only apply to the quill components used inside of the filepicker or libary. It shouldn't set/overwrite quill styling classes globaly.

Observed Behavior

I use the Filepicker component and another libary which also uses react-quill. When i add the filepicker component to my code the quill toolbar from the second libary is suddenly hidden with display set to none.
The FilePicker component in @pnp/spfx-controls-react applies global styles to the .ql-toolbar class using :global in its SCSS (also other quill classes are overwritten). This causes unintended side effects in projects where other react-quill editors are used, because the toolbar is hidden (display: none) globally for unrelated quill editors.
The styling comes from src\controls\richText\RichText.module.scss
:global {
.ql-toolbar {
background-color: transparent;
color: "[theme:neutralLighterAlt, default:#{$ms-color-neutralLighterAlt}]";
border: none;
display: none;
...

Steps to Reproduce

Use the react-quill libary in your project and add the filepicker component ->global styling from filepicker gets applied to the unrelated react-quill.

Thanks!

Copy link

Thank you for submitting your first issue to this project.

@AJIXuMuK AJIXuMuK added this to the 3.22.0 milestone Jun 2, 2025
@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jun 2, 2025
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jun 2, 2025

@ffischer06 - I have made the changes. Could you please verify on your end that the issue is fixed in beta version?
Thanks!

@ffischer06
Copy link
Author

@AJIXuMuK - This fixed the issue. Thanks!

@michaelmaillot michaelmaillot changed the title [Filepicker] Golbal quill styles from filepicker overwrite other quill editors [FilePicker] Golbal quill styles from FilePicker overwrite other quill editors Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

2 participants