fix quill global style issue #2006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR scopes global Quill styles to a specific container by adding a dedicated CSS class and updating the SCSS to target only that class.
- Adds a
pnp-richtext-quill-containerclass to the RichText wrapper - Wraps the global Quill toolbar styles under
.pnp-richtext-quill-containerin the SCSS
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/controls/richText/RichText.tsx | Added pnp-richtext-quill-container to the className call |
| src/controls/richText/RichText.module.scss | Changed :global to :global(.pnp-richtext-quill-container) to scope styles |
Comments suppressed due to low confidence (1)
src/controls/richText/RichText.tsx:639
- The base
styles.richtextclass is no longer included in thecss()call, which removes essential module styling for the container. Consider addingstyles.richtextunconditionally before other classes, e.g.:css(styles.richtext, this.state.editing && 'ql-active', 'pnp-richtext-quill-container', this.props.className).
styles.richtext && this.state.editing ? 'ql-active' : null,
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Fixes the issue with global quill style override