Skip to content

fix quill global style issue #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

fix quill global style issue #2006

merged 3 commits into from
Jun 2, 2025

Conversation

AJIXuMuK
Copy link
Collaborator

@AJIXuMuK AJIXuMuK commented Jun 2, 2025

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1996

What's in this Pull Request?

Fixes the issue with global quill style override

@AJIXuMuK AJIXuMuK requested a review from Copilot June 2, 2025 02:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR scopes global Quill styles to a specific container by adding a dedicated CSS class and updating the SCSS to target only that class.

  • Adds a pnp-richtext-quill-container class to the RichText wrapper
  • Wraps the global Quill toolbar styles under .pnp-richtext-quill-container in the SCSS

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/controls/richText/RichText.tsx Added pnp-richtext-quill-container to the className call
src/controls/richText/RichText.module.scss Changed :global to :global(.pnp-richtext-quill-container) to scope styles
Comments suppressed due to low confidence (1)

src/controls/richText/RichText.tsx:639

  • The base styles.richtext class is no longer included in the css() call, which removes essential module styling for the container. Consider adding styles.richtext unconditionally before other classes, e.g.: css(styles.richtext, this.state.editing && 'ql-active', 'pnp-richtext-quill-container', this.props.className).
styles.richtext && this.state.editing ? 'ql-active' : null,

@AJIXuMuK AJIXuMuK added this to the 3.22.0 milestone Jun 2, 2025
@AJIXuMuK AJIXuMuK merged commit 979e759 into dev Jun 2, 2025
1 check passed
@AJIXuMuK AJIXuMuK deleted the copilot-test branch June 2, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant