Update FolderExplorerService.ts to add import @pnp/sp/files #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the import @pnp/sp/files the methid _getFiles will fail as web.getFolderByServerRelativePath(folderRelativeUrl).files will be undefined and therfore the next .select will fail. adding the import fixed the issue
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the import @pnp/sp/files the methid _getFiles will fail as web.getFolderByServerRelativePath(folderRelativeUrl).files will be undefined and therfore the next .select will fail.
adding the import fixed the issue
What's in this Pull Request?
Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
When using the FolderExplorer with the option showFiles, the folderxplorer doesnt show the files + it shows the following error
Cannot read properties of undefined (reading 'select')
When investigating i found out that the import of pnp/sp/files was missing, which caused that the result of web.getFolderByServerRelativePath didnt contain a property files
Guidance