Conversation
KSXGitHub
requested changes
Sep 9, 2021
Collaborator
KSXGitHub
left a comment
There was a problem hiding this comment.
Can you use existing code style?
Member
|
Seems like a lot of changes were done. Will we finish this? |
Collaborator
|
@zkochan The diff is massive but I bet the actual change is minimal. OP just use a different code formatter from the one I use. Also, I am very reluctant to merge this. |
Author
|
For the past 3 months I have been using corepack and not using this action, and corepack has been working great. corepack lets you use a specific version specified in the package.json, handles all the downloading and install. I can close this pull request, unless there is someone else that wants to continue with it. |
|
For anyone who wants to download pnpm from a GitHub release instead of using Corepack, you can use this action instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support version ranges and tool caching, I updated the action to download from github releases. But then node 16.9 just came out with corepack built in. I switched my own projects to just using
actions/setup-nodeand runningcorepack enableand got rid of this action completely, but I thought I would still send a pull request.Features:
Removed:
I took out the call to
pnpm cache prune. I initially tried to keep it in but the problem is thepnpm cache pruneis run at the wrong time with the caching in setup-node. I plan on instead submitting a patch to actions/setup-node to run pnpm cache prune as part of the caching in actions/setup-node, but for now I just run pnpm cache prune as the final step in the job flow.