Repository navigation
Conversation
Co-Authored-By: Shotaro Nakamura <syoutarou1103@outlook.jp>
Contributor
|
Website preview: https://pr-132-eclipsa.xiarenda61.workers.dev Commit: 49e5fc2 |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the same action handle is invoked concurrently (double-click, rapid re-invoke),
invokewroteresult/error/lastSubmission/pendingafter awaits with no ordering guard, so an older submission resolving last would overwrite the newer result, andisPendingflipped tofalseas soon as any submission settled.Fix mirrors the version guard in
signal.tsand the router'ssequencecheck:The returned promise / async iterator still resolves with its own value; only the shared handle signals ignore superseded submissions. Single-submission behavior is unchanged.
Adds two unit tests in
core/action.test.ts(fail before, pass after).Link to Devin session: https://app.devin.ai/sessions/0cc06e7eec3c46019e2cca8c422b53de
Open in Devin Desktop: https://app.devin.ai/desktop/session/0cc06e7eec3c46019e2cca8c422b53de?variant=devin
Requested by: @nakasyou