Fix double encoding of URLs in normalize_url#219
Open
fredthomsen wants to merge 2 commits intopnuckowski:masterfrom
Open
Fix double encoding of URLs in normalize_url#219fredthomsen wants to merge 2 commits intopnuckowski:masterfrom
fredthomsen wants to merge 2 commits intopnuckowski:masterfrom
Conversation
Fix URLs being double encoded, as the yarl URL with_query method will re-encode any % values.
deejay1
approved these changes
Sep 13, 2023
Contributor
Author
|
@pnuckowski @deejay1 is there anything else that needs to be done with this PR? |
|
@pnuckowski Is there any update on this? The issue still exists and makes it hard to match URLs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix URLs being double encoded, as the yarl URL with_query method will
re-encode any % values.
Addresses #179.