Switch type comments to regular type annotations#277
Open
yangdanny97 wants to merge 1 commit intopnuckowski:masterfrom
Open
Switch type comments to regular type annotations#277yangdanny97 wants to merge 1 commit intopnuckowski:masterfrom
yangdanny97 wants to merge 1 commit intopnuckowski:masterfrom
Conversation
DanielNoord
approved these changes
Feb 10, 2026
Contributor
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
LGTM!
Would be nice to get this merged :)
Contributor
|
@pnuckowski Gentle ping on this one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library only supports v3.7+, so we can use regular type annotations instead of type comments. There are a few places that use the comment mostly because type comments do not error when attributes are initialized w/ None but annotated w/ something else, but I think we can just do a
type: ignorehere.