Open
Conversation
* try not to use time data unless temproally subsetting * fix tests
# Conflicts: # pyproject.toml
* fix the temporal subsettting for cygnss collections check for sample_time and solar_time * update changelog
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the 3.3.1 release by updating package metadata/docs and adjusting CYGNSS time-variable detection/handling during subsetting.
Changes:
- Bumps project version and refreshes locked dependencies.
- Makes temporal alignment in
subset_with_bboxtolerant of missing time variables. - Adjusts DataTree time-variable selection to handle a CYGNSS-specific
/sample_time→/solar_timenormalization; updates README/CHANGELOG accordingly.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Updates package version for the release. |
poetry.lock |
Dependency lock refresh (multiple version bumps + new transitive deps). |
podaac/subsetter/subset.py |
Wraps time var access to avoid KeyError when only spatial subsetting is used. |
podaac/subsetter/datatree_subset.py |
Adds CYGNSS-specific time-variable normalization logic in compute_time_variable_name_tree. |
README.md |
Updates CLI help text and documents additional subsetting/provenance options. |
CHANGELOG.md |
Adds a 3.3.1 changelog entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This workflow automatically, when team label is assigned to an issue: - Set podaac project status to triage - Assign to the team github project when it exists, with a New status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This workflow automatically, when team label is assigned to an issue: - Set podaac project status to triage - Assign to the team github project when it exists, with a New status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
@sliu008 can you check the copilot suggestions and update this? Thanks! |
Adds capability to recover dimension names for datatree given either GPM DimensionNames attributes or by parsing the ODL StructMetadata.0 present in HDFEOS files. Additionally updates GPM integration test to use correct data.
…es, but different sizes (#413) Some collections like OMPIXCOR_003 contain multiple swaths with the same dimension names assigned to variables, but with different sizes. This would throw off the current dimension mapping implementation. This updates ODL parser to track multiple dim sizes for a given dimension and parse on a scope basis instead of just assuming single swath group.
Update checks for ScanTime to occur for all file formats as opposed for only HDF files. If ScanTime is present, compute timeMidScan regardless of format. Added unit test and fake data fixture which mirrors existing structure of GPM V08.
* put in fix for MOPITT * removed print * restructure build_temporal_cond * update changelog
Contributor
|
Hi @jamesfwood , @sliu008 , do we want to keep this PR open as there are other updates that arrived since ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3.3.1]
Added
Changed
Deprecated
Removed
Fixed
Security