Skip to content

fix ssh config parsing for HostName#28874

Open
kila-star1127 wants to merge 1 commit into
podman-container-tools:mainfrom
kila-star1127:issue_25067
Open

fix ssh config parsing for HostName#28874
kila-star1127 wants to merge 1 commit into
podman-container-tools:mainfrom
kila-star1127:issue_25067

Conversation

@kila-star1127
Copy link
Copy Markdown

A later invocation to url.Parse() needs a preceding scheme, otherwise the hostname just gets discarded.

Fixes #25067


This is a re-submission of #27673 (authored by @Jannik2099)

The original PR is stalled due to the addition of tests.

The maintainers (@mheon, @giuseppe) agreed to merge without tests, but @mtrmac expressed concerns about the test content.

Since it was deemed acceptable to merge without tests, I removed them.


Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

Fix podman-remote being unable to connect to any host with a custom HostName in the user's ~/.ssh/config

A later invocation to url.Parse() needs a preceding scheme,
otherwise the hostname just gets discarded.

Fixes podman-container-tools#25067

Signed-off-by: Jannik Glückert <jannik.glueckert@gmail.com>
Signed-off-by: KILA <32559459+kila-star1127@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No connection could be made because the target machine actively refused it.

2 participants