Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Update everything #219

Closed
wants to merge 64 commits into from
Closed

Update everything #219

wants to merge 64 commits into from

Conversation

michikrug
Copy link

Since I was asked to update pgoapi to the latest changes, here it is...

Feel free to request changes!

List of changes:

  • add locale parameter

based on aiopogo:

  • update auth class
  • update PTC login flow

based on @sebastienvercammen changes:

  • integrate RPC_ID generation
  • reformat some files

@michikrug
Copy link
Author

michikrug commented Dec 17, 2017

Does anybody know about:
protos/pogoprotos/networking/platform/requests/plat_eight_request_pb2.py
protos/pogoprotos/networking/platform/responses/plat_eight_response_pb2.py

Since I have somehow merged them sometime and I do not know if they should be there.

[EDIT]
I removed them now.

@FrostTheFox
Copy link

FrostTheFox commented Dec 20, 2017

based on aiopogo:~~ ~~update PTC login flow~~ ~~
^ Wording here is a little misleading. The flow itself wasn't updated, just the code around it.

Also, the PTC headers are mostly good, I would update the UA to a more modern one (optional, the UA also is the same for plfe/version requests, unsure if pgoapi hits that or not). Also, Accept-Encoding is missing a value. Refer to my MITM: https://pst.fur.pm/yiyaxelimo.http

@michikrug
Copy link
Author

Well the URLs called / the order changed...

Thanks for the hints. I will have a look at the MITM.

@FrostTheFox
Copy link

Apologies, I must have confused some tabs when I was reviewing last night. The header part is still valid :)

@michikrug
Copy link
Author

Messed up the branch somehow.

Now please see #221

@michikrug michikrug closed this Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants