forked from woowacourse/java-chess
-
Notifications
You must be signed in to change notification settings - Fork 3
[4단계 - DB 적용] 이준섭 미션 제출합니다. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
junseoplee
wants to merge
23
commits into
poi1649:junseoplee
Choose a base branch
from
junseoplee:step4
base: junseoplee
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7d27a33
fix: 향상된 문법으로 equals 수정
junseoplee d6ca9b5
docs: 기능 요구 사항 업데이트
junseoplee 5e9f872
feat: 승리한 팀을 찾고 출력하는 기능 구현
junseoplee fba2d73
feat: King 이 잡혔을 때 승리 팀과 점수를 출력하는 기능 구현
junseoplee 90f634b
fix: Pawn 피스가 적이 없을 경우에도 대각선으로 움직일 수 있던 오류 수정
junseoplee 89edcb7
docs: 기능 요구 사항 정리
junseoplee 0218cec
refactor: 프로젝트 구조 수정
junseoplee c786f3d
feat: 게임별로 구분할 수 있는 ChessGame 클래스 구현, 저장할 수 있도록 상태를 나타내는 State 열거형 구현
junseoplee 5fd16d9
feat: DB 연결에 필요한 설정 추가
junseoplee 54b66b5
feat: DB 연결을 위한 ChessGameDao 기능 추가
junseoplee 9f7f78c
feat: DB 연결을 위한 PieceDao 기능 추가
junseoplee 037471d
feat: DB 연결을 위한 PieceDao 기능 추가
junseoplee 61d451a
fix: DB 연결을 위한 설정 수정
junseoplee 3f07391
refactor: Board 반환을 위한 리팩토링
junseoplee a4d293e
refactor: 진행 상태를 보다 명확하게 알 수 있도록 변경
junseoplee e20a260
feat: DB 연결 기능과 컨트롤러 조립
junseoplee 80b7e47
docs: 기능 요구 사항 및 에러메세지 업데이트
junseoplee a3ac67f
fix: 기존 게임이 정상적으로 불러와지지 않던 오류 수정
junseoplee ddfb961
refactor: 명령어를 다루는 책임을 컨트롤러에서 분리
junseoplee 7c6c78e
feat: UnsupportedOperationException 으로 사용되지 않는 메서드 관리
junseoplee 0ad0e65
test: 폰의 공격 움직임을 검증하는 테스트 추가
junseoplee 3ce712d
fix: 변수 이름을 명확하게 수정
junseoplee d5483e4
fix: 상태를 더 명확하게 나타낼 수 있는 이름으로 수정
junseoplee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| package chess.domain.game; | ||
|
|
||
| public enum State { | ||
| WAITING, | ||
| RUNNING, | ||
| FINISHED | ||
| START, | ||
| RUN, | ||
| END, | ||
| CHECKMATE | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkmate의 정의와 다르게 사용되고 있어서 오히려 혼란을 유발할 수도 있을 것 같네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
동의합니다. 보다 명확하게 나타낼 수 있도록 상태를 kingIsCaptured로 변경했습니다