forked from woowacourse/java-chess
-
Notifications
You must be signed in to change notification settings - Fork 3
[4단계 - DB 적용] 이유빈 미션 제출합니다 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leeshin20
wants to merge
5
commits into
poi1649:leeshin20
Choose a base branch
from
leeshin20:step4
base: leeshin20
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+297
−12
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,3 +30,4 @@ out/ | |
|
|
||
| ### VS Code ### | ||
| .vscode/ | ||
| .env | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package chess.utils; | ||
|
|
||
| import io.github.cdimascio.dotenv.Dotenv; | ||
| import java.sql.Connection; | ||
| import java.sql.DriverManager; | ||
| import java.sql.SQLException; | ||
|
|
||
| public class DatabaseUtil { | ||
| private static final Dotenv dotenv = Dotenv.load(); | ||
| private static final String URL = dotenv.get("DB_URL"); | ||
| private static final String USER = dotenv.get("DB_USER"); | ||
| private static final String PASSWORD = dotenv.get("DB_PASSWORD"); | ||
|
Comment on lines
+10
to
+12
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 라이브러리 사용 이유와는 별개로 DB 정보를 숨긴 것은 너무 좋네요 👍👍 질문
|
||
|
|
||
| public static Connection getConnection() throws SQLException { | ||
| return DriverManager.getConnection(URL, USER, PASSWORD); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 라이브러리를 선택한 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB 비밀번호 같은 민감한 정보를 Dotenv로 관리하는 것이 좋다고 알고 있었기에 선택했습니다.
해당 경우에 다른 선택지가 있는지는 자세히 알아보지는 않았습니다