Add support for throwing functions in .convert conversions #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add @_disfavoredOverload convert overload for throwing closures - Implement throwing initializer in AnyConversion with direct closure storage - Add comprehensive tests covering throwing and non-throwing scenarios - Maintain backward compatibility and overload disambiguation - Include detailed documentation with usage examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.convertconversions@_disfavoredOverloadto maintain backward compatibilityChanges
.convertAPI: Added overload that accepts throwingapplyandunapplyclosuresAnyConversion.init(apply: @escaping (Input) throws -> Output, unapply: @escaping (Output) throws -> Input)ConvertTests.swiftwith coverage for throwing/non-throwing scenarios and overload disambiguation.convertusage remains unchangedTest Plan
Implementation Details
The solution uses
@_disfavoredOverloadon the throwing overload to resolve compiler ambiguity, ensuring the non-throwing version is preferred when both signatures are compatible. The throwing initializer directly stores the throwing closures without additional wrapping, maximizing performance while providing the flexibility to throw custom errors instead of genericConvertingError.This complements the existing optional-based conversion by allowing developers to throw specific, meaningful errors when conversion logic fails, improving error handling and debugging experience.