Improve diffs for landscape orientation #690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When snapshot testing screenshots in landscape orientation, the diffs are very noisy as the original orientation of the reference image is ignored and it is treated, for the purpose of the visual diff, as a portrait orientation image. (The actual comparison seems to work correctly in a pass/fail sense, however.)
Unfortunately, this makes it very hard to see what actually changed. For example when removing a button in a drawing app I am currently working on, this is the diff I receive in the current version of the repository:
I believe this issue can be resolved by using the orientation from the new image for the visual diff which results in the following much more readable output:
I don't have enough context to know if my solution has drawbacks for the library/community as a whole so I would certainly appreciate review/discussion to see if there is a better solution.